linux-kernel - Re: [alsa-devel] [PATCH] ALSA: doc: fix snd_hda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5ha75mrbyb.wl-tiwai@suse.de>
Date:   Thu, 13 Feb 2020 11:58:04 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Radoslaw Smigielski <radoslaw.smigielski@...eria.pl>
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
        alsa-devel@...a-project.org, corbet@....net, tiwai@...e.com,
        perex@...ex.cz
Subject: Re: [alsa-devel] [PATCH] ALSA: doc: fix snd_hda_intel driver name

On Thu, 13 Feb 2020 11:36:37 +0100,
Radoslaw Smigielski wrote:
> 
> Update driver name snd-hda-intel to proper, existing driver
> name snd_hda_intel in Documentation/sound/hd-audio/notes.rst.

snd-hda-intel is correct from the module file name POV.
Both are handled equivalently.


thanks,

Takashi

> 
> Signed-off-by: Radoslaw Smigielski <radoslaw.smigielski@...eria.pl>
> ---
>  Documentation/sound/hd-audio/notes.rst | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/sound/hd-audio/notes.rst b/Documentation/sound/hd-audio/notes.rst
> index 0f3109d9abc8..56ccc15f4d26 100644
> --- a/Documentation/sound/hd-audio/notes.rst
> +++ b/Documentation/sound/hd-audio/notes.rst
> @@ -17,12 +17,12 @@ methods for the	HD-audio hardware.
>  
>  The HD-audio component consists of two parts: the controller chip and 
>  the codec chips on the HD-audio bus.  Linux provides a single driver
> -for all controllers, snd-hda-intel.  Although the driver name contains
> +for all controllers, snd_hda_intel.  Although the driver name contains
>  a word of a well-known hardware vendor, it's not specific to it but for
>  all controller chips by other companies.  Since the HD-audio
>  controllers are supposed to be compatible, the single snd-hda-driver
>  should work in most cases.  But, not surprisingly, there are known
> -bugs and issues specific to each controller type.  The snd-hda-intel
> +bugs and issues specific to each controller type.  The snd_hda_intel
>  driver has a bunch of workarounds for these as described below.
>  
>  A controller may have multiple codecs.  Usually you have one audio
> @@ -31,7 +31,7 @@ multiple audio codecs, e.g. for analog and digital outputs, and the
>  driver might not work properly because of conflict of mixer elements.
>  This should be fixed in future if such hardware really exists.
>  
> -The snd-hda-intel driver has several different codec parsers depending
> +The snd_hda_intel driver has several different codec parsers depending
>  on the codec.  It has a generic parser as a fallback, but this
>  functionality is fairly limited until now.  Instead of the generic
>  parser, usually the codec-specific parser (coded in patch_*.c) is used
> @@ -226,7 +226,7 @@ the external amplifier bits.  Thus a headphone output has a slightly
>  better chance.
>  
>  Before making a bug report, double-check whether the mixer is set up
> -correctly.  The recent version of snd-hda-intel driver provides mostly
> +correctly.  The recent version of snd_hda_intel driver provides mostly
>  "Master" volume control as well as "Front" volume (where Front
>  indicates the front-channels).  In addition, there can be individual
>  "Headphone" and "Speaker" controls.
> @@ -596,7 +596,7 @@ For example, if you have two cards, one for an on-board analog and one
>  for an HDMI video board, you may pass patch option like below:
>  ::
>  
> -    options snd-hda-intel patch=on-board-patch,hdmi-patch
> +    options snd_hda_intel patch=on-board-patch,hdmi-patch
>  
>  
>  Power-Saving
> -- 
> 2.24.1
>