linux-kernel - Re: [PATCH 3/3 RESEND] perf/amd/uncore: Add support for Family 19h L3 PMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200312141418.GE15619@zn.tnic>
Date:   Thu, 12 Mar 2020 15:14:18 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Kim Phillips <kim.phillips@....com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Jiri Olsa <jolsa@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Michael Petlan <mpetlan@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 3/3 RESEND] perf/amd/uncore: Add support for Family 19h
 L3 PMU

On Wed, Mar 11, 2020 at 02:13:23PM -0500, Kim Phillips wrote:
> Family 19h introduces a change in slice, core and thread specification
> in its L3 Performance Event Select (ChL3PmcCfg) register. We implement
> the new bitmask conversions in a new path in l3_thread_slice_mask()
> based on a family 19h-and-above check.
> 
> We also change the uncore_init() family check to 19h-and-above, so as
> to not revert to the Family 16h-or-below L2/NB code paths in the driver.

Pls use passive voice in your commit message: no "we" or "I", etc, and
describe your changes in imperative mood.

Also, pls read section "2) Describe your changes" in
Documentation/process/submitting-patches.rst for more details.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette