linux-kernel - Re: [PATCH v2] MIPS: c-r4k: Invalidate BMIPS5000 ZSCM prefetch lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2388CCC9-8C2A-4907-988D-7A239DE0DD6C@gmail.com>
Date:   Thu, 12 Mar 2020 23:09:35 -0400
From:   Kamal Dasu <kdasu.kdev@...il.com>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        linux-mips@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paulburton@...nel.org>,
        James Hogan <jhogan@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhc@...ote.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] MIPS: c-r4k: Invalidate BMIPS5000 ZSCM prefetch lines

This is needed on dma reads from device.  

Kamal


> On Mar 11, 2020, at 5:44 PM, Thomas Bogendoerfer <tsbogend@...ha.franken.de> wrote:
> 
> On Wed, Mar 11, 2020 at 01:54:23PM -0700, Florian Fainelli wrote:
>>> On 2/7/20 2:33 PM, Kamal Dasu wrote:
>>> Zephyr secondary cache is 256KB, 128B lines. 32B sectors. A secondary cache
>>> line can contain two instruction cache lines (64B), or four data cache
>>> lines (32B). Hardware prefetch Cache detects stream access, and prefetches
>>> ahead of processor access. Add support to invalidate BMIPS5000 cpu zephyr
>>> secondary cache module (ZSCM) on DMA from device so that data returned is
>>> coherent during DMA read operations.
>>> 
>>> Signed-off-by: Kamal Dasu <kdasu.kdev@...il.com>
>> 
>> Thomas can review and apply this patch? Thank you!
> 
> looks good to me. I only wonder whether r4k_dma_cache_wbinv() also
> needs this ?
> 
> Thomas.
> 
> -- 
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]