linux-kernel - Re: [PATCH v6 3/7] dt-bindings: clk: sprd: add bindings for sc9863a clock controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <158510180797.125146.1966913179385526344@swboyd.mtv.corp.google.com>
Date:   Tue, 24 Mar 2020 19:03:27 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Chunyan Zhang <zhang.lyra@...il.com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <chunyan.zhang@...soc.com>
Subject: Re: [PATCH v6 3/7] dt-bindings: clk: sprd: add bindings for sc9863a clock controller

Quoting Chunyan Zhang (2020-03-22 04:00:39)
> Hi Stephen,
> 
> On Sat, 21 Mar 2020 at 09:12, Stephen Boyd <sboyd@...nel.org> wrote:
> >
> > Quoting Chunyan Zhang (2020-03-03 23:27:26)
> > > From: Chunyan Zhang <chunyan.zhang@...soc.com>
> > >
> > > add a new bindings to describe sc9863a clock compatible string.
> > >
> > > Signed-off-by: Chunyan Zhang <chunyan.zhang@...soc.com>
> > [...]
> > > +examples:
> > > +  - |
> > > +    ap_clk: clock-controller@...00000 {
> > > +      compatible = "sprd,sc9863a-ap-clk";
> > > +      reg = <0 0x21500000 0 0x1000>;
> > > +      clocks = <&ext_26m>, <&ext_32k>;
> > > +      clock-names = "ext-26m", "ext-32k";
> > > +      #clock-cells = <1>;
> > > +    };
> > > +
> > > +  - |
> > > +    soc {
> > > +      #address-cells = <2>;
> > > +      #size-cells = <2>;
> > > +
> > > +      ap_ahb_regs: syscon@...00000 {
> > > +        compatible = "sprd,sc9863a-glbregs", "syscon", "simple-mfd";
> > > +        reg = <0 0x20e00000 0 0x4000>;
> > > +        #address-cells = <1>;
> > > +        #size-cells = <1>;
> > > +        ranges = <0 0 0x20e00000 0x4000>;
> > > +
> > > +        apahb_gate: apahb-gate@0 {
> >
> > Why do we need a node per "clk type" in the simple-mfd syscon? Can't we
> > register clks from the driver that matches the parent node and have that
> > driver know what sorts of clks are where? Sorry I haven't read the rest
> > of the patch series and I'm not aware if this came up before. If so,
> > please put details about this in the commit text.
> 
> Please see the change logs after v2 in cover-letter.
> 
> Rob suggested us to put some clocks under syscon nodes, since these
> clocks have the same
> physical address base with the syscon;

Ok. I'll apply the series to clk-next then.