linux-kernel - Re: [PATCH v2 10/10] objtool: Support multiple stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200402182549.GI20730@hirez.programming.kicks-ass.net>
Date:   Thu, 2 Apr 2020 20:25:49 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Julien Thierry <jthierry@...hat.com>, linux-kernel@...r.kernel.org,
        raphael.gault@....com
Subject: Re: [PATCH v2 10/10] objtool: Support multiple stack_op per
 instruction

On Thu, Apr 02, 2020 at 12:54:26PM -0500, Josh Poimboeuf wrote:
> On Fri, Mar 27, 2020 at 03:28:47PM +0000, Julien Thierry wrote:
> > @@ -127,6 +129,10 @@ int arch_decode_instruction(struct elf *elf, struct section *sec,
> >  	if (insn.sib.nbytes)
> >  		sib = insn.sib.bytes[0];
> >  
> > +	op = calloc(1, sizeof(*op));
> > +	if (!op)
> > +		return -1;
> > +
> 
> Why not malloc()?

calloc() does a memset(), I wondered the same and read the manpage ;-)