linux-kernel - Re: [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adb03545-88db-689c-dbf7-9f746236adb4@axis.com>
Date:   Tue, 21 Apr 2020 14:03:41 +0200
From:   Bjorn Ardo <bjorn.ardo@...s.com>
To:     Wolfram Sang <wsa@...-dreams.de>,
        Patrick Williams <patrick@...cx.xyz>
CC:     Björn Ardö <bjornar@...s.com>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] i2c: slave-eeprom: initialize empty eeprom properly

On 4/20/20 10:53 PM, Wolfram Sang wrote:

> On Mon, Apr 20, 2020 at 03:31:46PM -0500, Patrick Williams wrote:
>> On Mon, Apr 20, 2020 at 06:43:49PM +0200, Wolfram Sang wrote:
>>> On Wed, Oct 02, 2019 at 08:20:53AM +0200, Bjorn Ardo wrote:
>>>> Hi,
>>>>
>>>>
>>>> I sent in another patch earlier that added support for specifying a file in
>>>> devicetree to initilize the eeprom from, corresponding to the case of
>>>> pre-flashed eeprom. Maybe these two patches should be merged so this
>>>> initialization is only done if no file is specified?
>>> Yes, I agree.
>>>
>> It looks like Bjorn's referenced patches are still unmerged also?
> Yes, it might be easiest if he merges your patch (with attribution) into
> the else branch of his fw-load patch.
>

OK, so to summarize, I should update my patch to use 
device_property_read_string() instead and also init the memory to 0XFF 
if no file is present. And change name of the function to 
i2c_slave_init_eeprom_data.


I will look into that and let you know once I'm done.


/BA