linux-kernel - Re: [PATCH v3] checkpatch: add dedicated checker for 'Fixes:' tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2d7dbae193800ce430321d3fcc71ab5d1a5ed03.camel@perches.com>
Date:   Tue, 28 Apr 2020 16:17:03 -0700
From:   Joe Perches <joe@...ches.com>
To:     Wang YanQing <udknight@...il.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Andy Whitcroft <apw@...onical.com>, Markus.Elfring@....de,
        mcroce@...hat.com
Subject: Re: [PATCH v3] checkpatch: add dedicated checker for 'Fixes:' tag

On Tue, 2020-04-28 at 09:10 -0700, Joe Perches wrote:
> On Tue, 2020-04-28 at 10:02 +0800, Wang YanQing wrote:
> > According to submitting-patches.rst, 'Fixes:' tag has a little
> > stricter condition about the one line summary:
> > ...
> > Do not split the tag across multiple
> > lines, tags are exempt from the "wrap at 75 columns" rule in order to simplify
> > parsing scripts
> > ...
> > 
> > And there is no 'Fixes:' tag format checker in checkpatch to check
> > the commit id length too, so let's add dedicated checker to check
> > these conditions for 'Fixes:' tag.
> 
> There's no need to duplicate functionality like this.
> Put this additional Fixes: logic into the existing block.
> 
> (and don't take advise from Markus too seriously when it
> comes to English grammar or wording.  He is not an arbiter
> of taste for this code)
> 

btw:  I suggested this patch last year.

https://lore.kernel.org/lkml/40bfc40958fca6e2cc9b86101153aa0715fac4f7.camel@perches.com/