linux-kernel - Re: [PATCH -next] rtc: pcf8523: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200506093441.GB34497@piout.net>
Date:   Wed, 6 May 2020 11:34:41 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Samuel Zou <zou_wei@...wei.com>
Cc:     a.zummo@...ertech.it, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rtc: pcf8523: Use PTR_ERR_OR_ZERO() to simplify
 code

Hi,

On 06/05/2020 17:34:00+0800, Samuel Zou wrote:
> Fixes coccicheck warning:
> 
> drivers/rtc/rtc-pcf8523.c:361:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 

I'm not taking this change because it is useless and will have to be
revert as soon as the probe function changes (and it will).

Does it really simplifies the code? I very much doubt so.

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Samuel Zou <zou_wei@...wei.com>
> ---
>  drivers/rtc/rtc-pcf8523.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c
> index 47e0f41..da8889a 100644
> --- a/drivers/rtc/rtc-pcf8523.c
> +++ b/drivers/rtc/rtc-pcf8523.c
> @@ -358,10 +358,8 @@ static int pcf8523_probe(struct i2c_client *client,
>  
>  	rtc = devm_rtc_device_register(&client->dev, DRIVER_NAME,
>  				       &pcf8523_rtc_ops, THIS_MODULE);
> -	if (IS_ERR(rtc))
> -		return PTR_ERR(rtc);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(rtc);
>  }
>  
>  static const struct i2c_device_id pcf8523_id[] = {
> -- 
> 2.6.2
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com