linux-kernel - Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in sunxi_mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200609160448.cy47xfwqs6hkxi7d@gilmour.lan>
Date:   Tue, 9 Jun 2020 18:04:48 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Frank Lee <tiny.windzz@...il.com>
Cc:     Frank Lee <frank@...winnertech.com>, chaotian.jing@...iatek.com,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Chen-Yu Tsai <wens@...e.org>, rmfrfs@...il.com, marex@...x.de,
        linux-mmc@...r.kernel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-mediatek@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mmc: sunxi-mmc: do not hide address in
 sunxi_mmc_irq()

On Mon, Jun 08, 2020 at 08:54:51PM +0800, Frank Lee wrote:
> On Fri, Jun 5, 2020 at 11:18 PM Maxime Ripard <maxime@...no.tech> wrote:
> >
> > Hi,
> >
> > On Fri, Jun 05, 2020 at 08:55:44PM +0800, Frank Lee wrote:
> > > From: Yangtao Li <tiny.windzz@...il.com>
> > >
> > > Using %px to show the actual address in sunxi_mmc_irq()
> > > to help us to debug issue.
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
> > > Signed-off-by: Frank Lee <frank@...winnertech.com>
> >
> > I'm fairly sure this hash is on purpose, and both the commit log of the
> > %px introduction (ad67b74d2469) and the checkpatch message are pretty
> > explicit about it.
> >
> > What issue were you trying to solve here?
> 
> There doesn't seem to be a strong requirement to force this to be printed out,
> I just think that ____ptrval____ is very unpleasant.

That should happen only at boot when the system doesn't have enough
entropy iirc, after a while it prints out hashes.

> Or delete %p directly?

You mean the message in the driver? I'd be fine with that too.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)