[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200615120332.GJ4282@kadam>
Date: Mon, 15 Jun 2020 15:03:32 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Denis Efremov <efremov@...ux.com>
Cc: Joe Perches <joe@...ches.com>, Julia Lawall <Julia.Lawall@...6.fr>,
cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coccinelle: api: add kzfree script
On Sun, Jun 14, 2020 at 10:42:54PM +0300, Denis Efremov wrote:
> On 6/4/20 7:27 PM, Joe Perches wrote:
> > On Thu, 2020-06-04 at 17:08 +0300, Denis Efremov wrote:
> >> Check for memset() with 0 followed by kfree().
> >
> > Perhaps those uses should be memzero_explicit or kvfree_sensitive.
> >
>
> Is it safe to suggest to use kzfree instead of memzero_explicit && kfree?
> Or it would be better to use kvfree_sensitive in this case.
>
> kzfree uses memset(0) with no barrier_data.
Yeah. That seems buggy. It should have a barrier. Also I thought I
saw somewhere that Linus doesn't like the name and so that's why we have
the _sensitive() name?
regards,
dan carpenter
Powered by blists - more mailing lists