linux-kernel - Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in rpi_firmware_print_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Jun 2020 08:46:53 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Stefan Wahren <wahrenst@....net>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: Re: [PATCH v1] ARM: bcm2835: Fix integer overflow in
 rpi_firmware_print_firmware_revision()

On Tue 2020-06-16 18:42:00, Nicolas Saenz Julienne wrote:
> On Tue, 2020-06-16 at 19:31 +0300, Andy Shevchenko wrote:
> > time64_t is 64-bit width type, we are not supposed to supply lesser ones
> > as in the case of rpi_firmware_print_firmware_revision() after the commit
> > 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT"). Use temporary variable
> > of time64_t type to correctly handle lesser types.
> > 
> > Fixes: 4a60f58ee002 ("ARM: bcm2835: Switch to use %ptT")
> > Reported-by: Stefan Wahren <wahrenst@....net>
> > Reported-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Cc: Petr Mladek <pmladek@...e.com>
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > ---
> 
> Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>

Revieved-by: Petr Mladek <pmladek@...e.com>

> If this doesn't fit the printk tree I don't mind taking it trough the rpi soc
> tree.
> 
> I'll also update the MAINTAINERS file so the firmware driver isn't orphaned.

I agree with Sergey that this should better go via SOC tree.

That said, feel free to ask to take it via printk tree. It has caused
the regression after all ;-)

Best Regards,
Petr