linux-kernel - Re: [PATCH -next] arm64: Export __cpu_logical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200724094336.GA22178@infradead.org>
Date:   Fri, 24 Jul 2020 10:43:36 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Mikko Perttunen <mperttunen@...dia.com>,
        Sumit Gupta <sumitg@...dia.com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Hulk Robot <hulkci@...wei.com>,
        "linux-kernel@...r.kernel.org List" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] arm64: Export __cpu_logical_map

On Fri, Jul 24, 2020 at 11:08:03AM +0800, Kefeng Wang wrote:
> +maillist
> 
> On 2020/7/24 11:04, Kefeng Wang wrote:
> > ERROR: modpost: "__cpu_logical_map" [drivers/cpufreq/tegra194-cpufreq.ko] undefined!
> > 
> > ARM64 tegra194-cpufreq driver use cpu_logical_map, export
> > __cpu_logical_map to fix build issue.
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> > ---
> >   arch/arm64/kernel/setup.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
> > index c793276ec7ad9..3aea05fbb9998 100644
> > --- a/arch/arm64/kernel/setup.c
> > +++ b/arch/arm64/kernel/setup.c
> > @@ -275,6 +275,7 @@ static int __init reserve_memblock_reserved_regions(void)
> >   arch_initcall(reserve_memblock_reserved_regions);
> >   u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID };
> > +EXPORT_SYMBOL(__cpu_logical_map);

EXPORT_SYMBOL_GPL, please.  Also consider turning the wrapper into
an out of line function instead of exporting the data structure.