linux-kernel - Re: [PATCH v7 3/3] ARM: dts: stm32: add initial support for stm32mp157-odyssey board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73c2439a-0250-4010-ad5d-601ac9f4b7df@pengutronix.de>
Date:   Sun, 9 Aug 2020 19:40:53 +0200
From:   Ahmad Fatoum <a.fatoum@...gutronix.de>
To:     Marcin Sloniewski <marcin.sloniewski@...il.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     robh+dt@...nel.org, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, mani@...nel.org, sam@...nborg.org,
        linus.walleij@...aro.org, arnd@...db.de, broonie@...nel.org,
        lkundrak@...sk, daniel@...f.com, kuninori.morimoto.gx@...esas.com,
        allen.chen@....com.tw, robh@...nel.org, devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 3/3] ARM: dts: stm32: add initial support for
 stm32mp157-odyssey board

Hello Marcin,

On 8/9/20 6:44 PM, Marcin Sloniewski wrote:
> Add support for Seeed Studio's stm32mp157c odyssey board.
> Board consists of SoM with stm32mp157c with 4GB eMMC and 512 MB DDR3 RAM
> and carrier board with USB and ETH interfaces, SD card connector,
> wifi and BT chip AP6236.
> 
> In this patch only basic kernel boot is supported and interfacing
> SD card and on-board eMMC.
> 
> Signed-off-by: Marcin Sloniewski <marcin.sloniewski@...il.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

> ---

> +
> +&rng1 {
> +	status = "okay";
> +};

I think we should put this into the SoC dtsi instead.

Cheers
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |