linux-kernel - Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Aug 2020 14:18:59 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Alex Dewar <alex.dewar90@...il.com>
Cc:     dennis.dalessandro@...el.com, dledford@...hat.com,
        gustavo@...eddedor.com, jgg@...pe.ca, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, mike.marciniszyn@...el.com,
        roland@...estorage.com
Subject: Re: [PATCH v2 1/2] IB/qib: remove superfluous fallthrough statements

Hi,

On Tue, Aug 25, 2020 at 02:33:27PM -0500, Gustavo A. R. Silva wrote:
> On Tue, Aug 25, 2020 at 06:12:42PM +0100, Alex Dewar wrote:
> > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which
> > were later converted to fallthrough statements by commit df561f6688fe
> > ("treewide: Use fallthrough pseudo-keyword"). This triggered a Coverity
> > warning about unreachable code.
> >
> 
> It's worth mentioning that this warning is triggered only by compilers
> that don't support __attribute__((__fallthrough__)), which has been
> supported since GCC 7.1.
> 
> > Remove the fallthrough statements.
> > 
> > Addresses-Coverity: ("Unreachable code")
> > Fixes: 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> > Signed-off-by: Alex Dewar <alex.dewar90@...il.com>
> 
> Reviewed-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> 

I can take this in my tree for 5.9-rc3.

Thanks
--
Gustavo