linux-kernel - Re: [PATCH 0/4] Remove LPC register partitioning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Sep 2020 15:41:41 +0930
From:   "Andrew Jeffery" <andrew@...id.au>
To:     "Ryan Chen" <ryan_chen@...eedtech.com>,
        "Chia-Wei, Wang" <chiawei_wang@...eedtech.com>,
        "Joel Stanley" <joel@....id.au>
Cc:     "Robert Lippert" <rlippert@...gle.com>,
        linux-aspeed <linux-aspeed@...ts.ozlabs.org>,
        "Corey Minyard" <minyard@....org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "OpenBMC Maillist" <openbmc@...ts.ozlabs.org>,
        "Rob Herring" <robh+dt@...nel.org>,
        "Linux ARM" <linux-arm-kernel@...ts.infradead.org>,
        "Cyril Bur" <cyrilbur@...il.com>,
        "Haiyue Wang" <haiyue.wang@...ux.intel.com>
Subject: Re: [PATCH 0/4] Remove LPC register partitioning

On Mon, 28 Sep 2020, at 17:13, Ryan Chen wrote:
> Hello Joel & Andrew,
> 	Those patches are more organize for ASPEED SOC LPC register layout. 
> 	Does those patches have any feedback?

I support getting the problem fixed. However, the series also needs to fix the 
LPC devicetree binding at

Documentation/devicetree/bindings/mfd/aspeed-lpc.txt

What's proposed isn't backwards compatible. We need to agree that a breaking 
change is the way we want to go and get Rob's buy-in. Given the impact of the 
change I'd prefer we don't try to maintain backwards compatibility. All known 
users of the binding ship the dtb with the kernel.

Can we get a v2 with the binding documentation fixed? That will probably need
some review.

Andrew