linux-kernel - Re: [PATCH v2 5/5] drm/i915/display: Introduce DEFINE_SHOW_STORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Oct 2020 19:06:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Luo Jiaxing <luojiaxing@...wei.com>, akpm@...ux-foundation.org,
        viro@...iv.linux.org.uk, andriy.shevchenko@...ux.intel.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        martin.petersen@...cle.com, john.garry@...wei.com,
        himanshu.madhani@...ium.com, felipe.balbi@...ux.intel.com,
        gregkh@...uxfoundation.org, uma.shankar@...el.com
Subject: Re: [PATCH v2 5/5] drm/i915/display: Introduce
 DEFINE_SHOW_STORE_ATTRIBUTE for debugfs

Hi Luo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next linus/master v5.10-rc1 next-20201030]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luo-Jiaxing/Introduce-a-new-helper-marco-DEFINE_SHOW_STORE_ATTRIBUTE-at-seq_file-c/20201030-165139
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/874380b0aa5ca9c7b02e5d7a1aa9a232c46999d9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luo-Jiaxing/Introduce-a-new-helper-marco-DEFINE_SHOW_STORE_ATTRIBUTE-at-seq_file-c/20201030-165139
        git checkout 874380b0aa5ca9c7b02e5d7a1aa9a232c46999d9
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/drm/drm_debugfs.h:36,
                    from drivers/gpu/drm/i915/display/intel_display_debugfs.c:6:
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:1788:29: error: redefinition of 'i915_hpd_short_storm_ctl_open'
    1788 | DEFINE_SHOW_STORE_ATTRIBUTE(i915_hpd_short_storm_ctl);
         |                             ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/seq_file.h:195:12: note: in definition of macro 'DEFINE_SHOW_STORE_ATTRIBUTE'
     195 | static int __name ## _open(struct inode *inode, struct file *file) \
         |            ^~~~~~
   drivers/gpu/drm/i915/display/intel_display_debugfs.c:1735:1: note: previous definition of 'i915_hpd_short_storm_ctl_open' was here
    1735 | i915_hpd_short_storm_ctl_open(struct inode *inode, struct file *file)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/i915/display/intel_display_debugfs.c:1735:1: warning: 'i915_hpd_short_storm_ctl_open' defined but not used [-Wunused-function]

vim +/i915_hpd_short_storm_ctl_open +1788 drivers/gpu/drm/i915/display/intel_display_debugfs.c

  1787	
> 1788	DEFINE_SHOW_STORE_ATTRIBUTE(i915_hpd_short_storm_ctl);
  1789	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (45913 bytes)