linux-kernel - Re: [PATCH 02/10] kernel: entry: Expose helpers to migrate TIF to SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201114112249.GA20070@infradead.org>
Date:   Sat, 14 Nov 2020 11:22:49 +0000
From:   Christoph Hellwig <hch@...radead.org>
To:     Gabriel Krisman Bertazi <krisman@...labora.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, keescook@...omium.org,
        arnd@...db.de, luto@...capital.net, wad@...omium.org,
        rostedt@...dmis.org, paul@...l-moore.com, eparis@...hat.com,
        oleg@...hat.com, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org, kernel@...labora.com
Subject: Re: [PATCH 02/10] kernel: entry: Expose helpers to migrate TIF to
 SYSCALL_WORK flags

> +#ifdef CONFIG_GENERIC_ENTRY
> +static inline void __set_task_syscall_work(struct thread_info *ti, int flag)
> +{
> +	set_bit(flag, (unsigned long *)&ti->syscall_work);
> +}
> +static inline int __test_task_syscall_work(struct thread_info *ti, int flag)
> +{
> +	return test_bit(flag, (unsigned long *)&ti->syscall_work);
> +}
> +static inline void __clear_task_syscall_work(struct thread_info *ti, int flag)
> +{
> +	return clear_bit(flag, (unsigned long *)&ti->syscall_work);

The casts here look bogus.