linux-kernel - Re: [PATCH] netfilter: conntrack: fix -Wformat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Dec 2020 15:40:12 +0100
From:   Lukas Bulwahn <lukas.bulwahn@...il.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Tom Rix <trix@...hat.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Joe Perches <joe@...ches.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        Dwaipayan Ray <dwaipayanray1@...il.com>
Subject: Re: [PATCH] netfilter: conntrack: fix -Wformat

On Thu, Dec 3, 2020 at 2:44 PM Miguel Ojeda
<miguel.ojeda.sandonis@...il.com> wrote:
>
> On Thu, Dec 3, 2020 at 8:26 AM Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:
> >
> > It is not a competition between checkpatch and clang-format, but if it would be:
>
> Please note that clang-tidy is a different tool, it is designed to
> write lints based on the AST rather than formatting.
>
> > But jokes aside: Dwaipayan Ray, a mentee Joe and I are working with,
> > has already submitted a patch to checkpatch that identifies those
> > patterns and provides a fix:
> >
> > https://lore.kernel.org/lkml/20201128200046.78739-1-dwaipayanray1@gmail.com/
>
> That is very good! However, it does not hurt to have it repeated in
> clang-tidy too: it is a very good thing to have a full C parser behind
> when writing lints!
>

Completely agree. A regular expression is only a limited (but quite
powerful) heuristics to a full C parser :)

... and it did a good job in the case here.

Lukas

> Cheers,
> Miguel