linux-kernel - Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afd6edda-460c-8488-6e63-438053e88eac@kernel.dk>
Date:   Mon, 7 Dec 2020 08:01:03 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Colin King <colin.king@...onical.com>,
        Danil Kipnis <danil.kipnis@...ud.ionos.com>,
        Jack Wang <jinpu.wang@...ud.ionos.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Bart Van Assche <bvanassche@....org>,
        linux-block@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] block/rnbd: fix a null pointer dereference on
 dev->blk_symlink_name

On 12/7/20 7:54 AM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently in the case where dev->blk_symlink_name fails to be allocates
> the error return path attempts to set an end-of-string character to
> the unallocated dev->blk_symlink_name causing a null pointer dereference
> error. Fix this by returning with an explicity ENOMEM error (which also
> is missing in the original code as was not initialized).

Applied, thanks.

-- 
Jens Axboe