linux-kernel - Re: [PATCH v2 0/5] Some cleanups and improvements for blk-iocost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2aad8cc-2fb4-015a-30b2-ff8f2b5e6ad6@kernel.dk>
Date:   Mon, 7 Dec 2020 08:02:06 -0700
From:   Jens Axboe <axboe@...nel.dk>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>, tj@...nel.org
Cc:     baolin.wang7@...il.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] Some cleanups and improvements for blk-iocost

On 11/26/20 1:16 AM, Baolin Wang wrote:
> Hi,
> 
> This patch set did some cleanups and improvements for blk-iocost, and
> no big functional changes. Please help to review. Thanks.
> 
> Changes from v1:
>  - Add acked-by tag from Tejun.
>  - Drop 2 unnecessary patches.
>  - Move the related variable declarations inside the block together
>  with the code in patch 3.
>  - Move the commit_weights() into ioc_check_iocgs().
>  - Move more related logics of adjusting base vrate into the
>  ioc_adjust_base_vrate().
>  - Rename the new functions.
> 
> Baolin Wang (5):
>   blk-iocost: Fix some typos in comments
>   blk-iocost: Remove unnecessary advance declaration
>   blk-iocost: Move the usage ratio calculation to the correct place
>   blk-iocost: Factor out the active iocgs' state check into a separate
>     function
>   blk-iocost: Factor out the base vrate change into a separate function
> 
>  block/blk-iocost.c | 251 +++++++++++++++++++++++++++++------------------------
>  1 file changed, 137 insertions(+), 114 deletions(-)

Applied, thanks.

-- 
Jens Axboe