linux-kernel - Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMGffEmKW=wa3_UiJA9+SLKcB0q9WmOMThQwoe0pc9oQQ62phA@mail.gmail.com>
Date:   Mon, 7 Dec 2020 16:02:34 +0100
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Jens Axboe <axboe@...nel.dk>, Colin King <colin.king@...onical.com>
Cc:     Danil Kipnis <danil.kipnis@...ud.ionos.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Bart Van Assche <bvanassche@....org>,
        linux-block <linux-block@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

On Mon, Dec 7, 2020 at 4:01 PM Jens Axboe <axboe@...nel.dk> wrote:
>
> On 12/7/20 7:54 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> >
> > Currently in the case where dev->blk_symlink_name fails to be allocates
> > the error return path attempts to set an end-of-string character to
> > the unallocated dev->blk_symlink_name causing a null pointer dereference
> > error. Fix this by returning with an explicity ENOMEM error (which also
> > is missing in the original code as was not initialized).
>
> Applied, thanks.

Thanks Colin for the fix, and thanks Jens for taking care of this.

Jack Wang