linux-kernel - Re: [PATCH v3 2/5] dt-bindings: riscv: microchip: Add YAML documentation for the PolarFire SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201209233011.GA1276461@robh.at.kernel.org>
Date:   Wed, 9 Dec 2020 17:30:11 -0600
From:   Rob Herring <robh@...nel.org>
To:     Atish Patra <atish.patra@....com>
Cc:     linux-kernel@...r.kernel.org, Albert Ou <aou@...s.berkeley.edu>,
        Alistair Francis <alistair.francis@....com>,
        Anup Patel <anup.patel@....com>,
        Bin Meng <bin.meng@...driver.com>, devicetree@...r.kernel.org,
        linux-riscv@...ts.infradead.org,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Ivan.Griffin@...rochip.com, Cyril.Jean@...rochip.com,
        Daire McNamara <daire.mcnamara@...rochip.com>,
        Conor.Dooley@...rochip.com
Subject: Re: [PATCH v3 2/5] dt-bindings: riscv: microchip: Add YAML
 documentation for the PolarFire SoC

On Fri, Dec 04, 2020 at 12:58:32AM -0800, Atish Patra wrote:
> Add YAML DT binding documentation for the Microchip PolarFire SoC.
> It is documented at:
> 
> https://www.microsemi.com/products/fpga-soc/polarfire-soc-icicle-quick-start-guide
> 
> Signed-off-by: Atish Patra <atish.patra@....com>
> ---
>  .../devicetree/bindings/riscv/microchip.yaml  | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/riscv/microchip.yaml
> 
> diff --git a/Documentation/devicetree/bindings/riscv/microchip.yaml b/Documentation/devicetree/bindings/riscv/microchip.yaml
> new file mode 100644
> index 000000000000..66e63c2bf359
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/microchip.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR MIT)

See what checkpatch.pl says.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/microchip.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip PolarFire SoC-based boards device tree bindings
> +
> +maintainers:
> +  - Cyril Jean <Cyril.Jean@...rochip.com>
> +  - Lewis Hanly <lewis.hanly@...rochip.com>
> +
> +description:
> +  Microchip PolarFire SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    items:
> +      - enum:
> +          - microchip,mpfs-icicle-kit
> +      - const: microchip,polarfire-soc
> +      - const: microchip,mpfs

Is this last compatible really useful? Usually better to just have SoC 
and board (or SoM plus baseboard) compatibles.

Rob