linux-kernel - Re: [NEEDS-REVIEW] [RFC PATCH 7/8] crypto: x86/aes-kl - Support AES algorithm using Key Locker instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8353acb0-03cf-a334-b505-416e0fc58b63@intel.com>
Date:   Thu, 17 Dec 2020 12:58:34 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Chang S. Bae" <chang.seok.bae@...el.com>, tglx@...utronix.de,
        mingo@...nel.org, bp@...e.de, luto@...nel.org, x86@...nel.org,
        herbert@...dor.apana.org.au
Cc:     dan.j.williams@...el.com, ravi.v.shankar@...el.com,
        ning.sun@...el.com, kumar.n.dwarakanath@...el.com,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [NEEDS-REVIEW] [RFC PATCH 7/8] crypto: x86/aes-kl - Support AES
 algorithm using Key Locker instructions

On 12/16/20 9:41 AM, Chang S. Bae wrote:
> +config CRYPTO_AES_KL
> +	tristate "AES cipher algorithms (AES-KL)"
> +	depends on X86_KEYLOCKER
> +	select CRYPTO_AES_NI_INTEL
> +	help
> +	  Use AES Key Locker instructions for AES algorithm.
> +
> +	  AES cipher algorithms (FIPS-197). AES uses the Rijndael
> +	  algorithm.
> +
> +	  Rijndael appears to be consistently a very good performer in both
> +	  hardware and software across a wide range of computing
> +	  environments regardless of its use in feedback or non-feedback
> +	  modes. Its key setup time is excellent, and its key agility is
> +	  good. Rijndael's very low memory requirements make it very well
> +	  suited for restricted-space environments, in which it also
> +	  demonstrates excellent performance. Rijndael's operations are
> +	  among the easiest to defend against power and timing attacks.
> +
> +	  The AES specifies three key sizes: 128, 192 and 256 bits
> +
> +	  See <http://csrc.nist.gov/encryption/aes/> for more information.
> +
> +	  For 128- and 256-bit keys, the AES cipher algorithm is
> +	  implemented by AES Key Locker instructions. This implementation
> +	  does not need an AES key once wrapped to an encoded form. For AES
> +	  compliance, 192-bit is processed by AES-NI instructions.

Giving a history lesson and high-level overview of AES doesn't quite
seem appropriate here, unless this is the first the kernel has seen of AES.