linux-kernel - Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including SEV-ES support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2262feb0-830e-1e05-d81b-031d54cf6853@redhat.com>
Date:   Mon, 18 Jan 2021 21:30:35 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, Tom Lendacky <thomas.lendacky@....com>,
        Brijesh Singh <brijesh.singh@....com>
Subject: Re: [PATCH] x86/sev: Add AMD_SEV_ES_GUEST Kconfig for including
 SEV-ES support

On 18/01/21 21:26, Borislav Petkov wrote:
> On Mon, Jan 18, 2021 at 06:59:38PM +0100, Paolo Bonzini wrote:
>> On 16/01/21 01:25, Sean Christopherson wrote:
>>>
>>> @@ -1527,12 +1527,14 @@ config AMD_MEM_ENCRYPT
>>>   	select DYNAMIC_PHYSICAL_MASK
>>>   	select ARCH_USE_MEMREMAP_PROT
>>>   	select ARCH_HAS_FORCE_DMA_UNENCRYPTED
>>> -	select INSTRUCTION_DECODER
>>>   	help
>>>   	  Say yes to enable support for the encryption of system memory.
>>>   	  This requires an AMD processor that supports Secure Memory
>>>   	  Encryption (SME).
>>> +	  This also enables support for running as a Secure Encrypted
>>> +	  Virtualization (SEV) guest.
>>> +
>>>   config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT
>>>   	bool "Activate AMD Secure Memory Encryption (SME) by default"
>>>   	default y
>>> @@ -1547,6 +1549,15 @@ config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT
>>>   	  If set to N, then the encryption of system memory can be
>>>   	  activated with the mem_encrypt=on command line option.
>>> +config AMD_SEV_ES_GUEST
>>> +	bool "AMD Secure Encrypted Virtualization - Encrypted State (SEV-ES) Guest support"
>>> +	depends on AMD_MEM_ENCRYPT
>>> +	select INSTRUCTION_DECODER
>>> +	help
>>> +	  Enable support for running as a Secure Encrypted Virtualization -
>>> +	  Encrypted State (SEV-ES) Guest.  This enables SEV-ES boot protocol
>>> +	  changes, #VC handling, SEV-ES specific hypercalls, etc...
>>> +
>>
>> Queued, thanks.
> 
> Say, Paolo, why are you queuing a patch which goes through tip, if at all?

Right you are, unqueued.  I would have caught the mistake before 
actually crystallizing the hashes, but thanks for noticing!

Sean, please send a v2 that removes the help change for AMD_MEM_ENCRYPT, 
too.

Thanks,

Paolo