linux-kernel - Re: [PATCH v4 4/5] mm: Use is_cow_mapping() across tree where proper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210209174601.GJ4718@ziepe.ca>
Date:   Tue, 9 Feb 2021 13:46:01 -0400
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Peter Xu <peterx@...hat.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Matthew Wilcox <willy@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        David Gibson <david@...son.dropbear.id.au>,
        Kirill Shutemov <kirill@...temov.name>,
        Christoph Hellwig <hch@....de>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Gal Pressman <galpress@...zon.com>,
        Jann Horn <jannh@...gle.com>, Jan Kara <jack@...e.cz>,
        Wei Zhang <wzam@...zon.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        VMware Graphics <linux-graphics-maintainer@...are.com>,
        Roland Scheidegger <sroland@...are.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: [PATCH v4 4/5] mm: Use is_cow_mapping() across tree where proper

On Mon, Feb 08, 2021 at 10:02:28PM -0500, Peter Xu wrote:
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 71ccec5c3817..620700f05ff4 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3733,15 +3733,13 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
>  	pte_t *src_pte, *dst_pte, entry, dst_entry;
>  	struct page *ptepage;
>  	unsigned long addr;
> -	int cow;
> +	int cow = is_cow_mapping(vma->vm_flags);

int should be bool

Otherwise looks fine to me 

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason