linux-kernel - Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f25d05b2470f66ddf174e4b64545ecc486a98d81.camel@microchip.com>
Date:   Mon, 15 Feb 2021 09:27:11 +0000
From:   <Bjarni.Jonasson@...rochip.com>
To:     <andrew@...n.ch>
CC:     <linux-kernel@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>,
        <Steen.Hegelund@...rochip.com>, <linux@...linux.org.uk>,
        <f.fainelli@...il.com>, <kuba@...nel.org>,
        <netdev@...r.kernel.org>, <vladimir.oltean@....com>,
        <davem@...emloft.net>, <hkallweit1@...il.com>,
        <atenart@...nel.org>, <ioana.ciornei@....com>
Subject: Re: [PATCH net v1 1/3] net: phy: mscc: adding LCPLL reset to VSC8514

On Fri, 2021-02-12 at 16:54 +0100, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Fri, Feb 12, 2021 at 03:06:41PM +0100, Bjarni Jonasson wrote:
> > At Power-On Reset, transients may cause the LCPLL to lock onto a
> > clock that is momentarily unstable. This is normally seen in QSGMII
> > setups where the higher speed 6G SerDes is being used.
> > This patch adds an initial LCPLL Reset to the PHY (first instance)
> > to avoid this issue.
> 
> Hi Bjarni
> 
> 
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> 
> These patches are rather large for stable, and not obviously correct.
> 
> There these problems hitting real users running stable kernels? Or is
> it so broken it never really worked?
> 
>    Andrew

Correct, the current linux driver is unstable and has never really
worked properly.  Our in-house SDK driver already have these fixes and
the upstreamed version has been lagging behind.  And yes the patches
are big, we had to pull out the calibration from the 8051 into the
driver.