[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <527e8905-d727-3a45-f542-5827fa0bca47@gmx.de>
Date: Tue, 16 Feb 2021 20:08:10 +0100
From: Lino Sanfilippo <LinoSanfilippo@....de>
To: Jarkko Sakkinen <jarkko@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>
Cc: peterhuewe@....de, stefanb@...ux.vnet.ibm.com,
James.Bottomley@...senpartnership.com,
linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
Lino Sanfilippo <l.sanfilippo@...bus.com>,
stable@...r.kernel.org
Subject: Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip
Hi,
On 16.02.21 at 17:11, Jarkko Sakkinen wrote:
> On Tue, Feb 16, 2021 at 06:09:50PM +0200, Jarkko Sakkinen wrote:
>> On Tue, Feb 16, 2021 at 06:04:42PM +0200, Jarkko Sakkinen wrote:
>>> On Tue, Feb 16, 2021 at 08:53:42AM -0400, Jason Gunthorpe wrote:
>>>> On Tue, Feb 16, 2021 at 01:31:00AM +0100, Lino Sanfilippo wrote:
>>>>>
>>>>> +static int tpm_add_tpm2_char_device(struct tpm_chip *chip)
>>>
>>> BTW, this naming is crap.
>>>
>>> - 2x tpm
>>> - char is useless
>>>
>>> -> tpm2_add_device
>>
>> Actually, tpm2s_add_device() add put it to tpm2-space.c.
>
> No, tpms_add_device() :-)
>
> (sorry)
>
> /Jarkko
>
I strongly assume you mean tmp2_add_device() :) I will move and rename the function
accordingly.
Thanks,
Lino
Powered by blists - more mailing lists