linux-kernel - Re: [PATCH v4] tpm: fix reference counting for struct tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Feb 2021 20:15:23 +0100
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Jarkko Sakkinen <jarkko@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>
Cc:     peterhuewe@....de, stefanb@...ux.vnet.ibm.com,
        James.Bottomley@...senpartnership.com,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        Lino Sanfilippo <l.sanfilippo@...bus.com>,
        stable@...r.kernel.org, David Laight <David.Laight@...LAB.COM>
Subject: Re: [PATCH v4] tpm: fix reference counting for struct tpm_chip

Hi

On 16.02.21 at 17:04, Jarkko Sakkinen wrote:

>>> +	/*
>>> +	 * get extra reference on main device to hold on behalf of devs.
>>> +	 * This holds the chip structure while cdevs is in use. The
>>> +	 * corresponding put is in the tpm_devs_release.
>>> +	 */
>>> +	get_device(&chip->dev);
>>> +	chip->devs.release = tpm_devs_release;
>>> +	chip->devs.devt =
>>> +		MKDEV(MAJOR(tpm_devt), chip->dev_num + TPM_NUM_DEVICES);
>
> Isn't this less than 100 chars?
>

I just chose the same formatting that the original code used. Personally I prefer what
David suggested, so if there is no objection against it I will format it this way.

Regards,
Lino