linux-kernel - Re: [PATCH v24 1/4] scsi: ufs: Introduce HPB feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50f8a0963e887542a467e690b6d406675279a4e5.camel@gmail.com>
Date:   Thu, 25 Feb 2021 15:38:12 +0100
From:   Bean Huo <huobean@...il.com>
To:     daejun7.park@...sung.com, Greg KH <gregkh@...uxfoundation.org>,
        "avri.altman@....com" <avri.altman@....com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "asutoshd@...eaurora.org" <asutoshd@...eaurora.org>,
        "stanley.chu@...iatek.com" <stanley.chu@...iatek.com>,
        "cang@...eaurora.org" <cang@...eaurora.org>,
        "bvanassche@....org" <bvanassche@....org>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
Cc:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        JinHwan Park <jh.i.park@...sung.com>,
        Javier Gonzalez <javier.gonz@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>
Subject: Re: [PATCH v24 1/4] scsi: ufs: Introduce HPB feature

On Wed, 2021-02-24 at 13:54 +0900, Daejun Park wrote:
> 
> +void ufshpb_init(struct ufs_hba *hba)
> +{
> +	struct ufshpb_dev_info *hpb_dev_info = &hba->ufshpb_dev;
> +	int try;
> +	int ret;
> +
> +	if (!ufshpb_is_allowed(hba))
> +		return;
> +

Here it is better to check "dev_info->hpb_enable", if HPB is not
enabled from UFS device level,  doesn't need to create mempool and take
other memory resource.

Bean