linux-kernel - Re: [PATCH] dma-buf: use wake_up_process() instead of wake_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7932bf4-611d-99c4-e138-549b298739f5@amd.com>
Date:   Fri, 19 Mar 2021 09:07:08 +0100
From:   Christian König <christian.koenig@....com>
To:     Wang Qing <wangqing@...o.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Gustavo Padovan <gustavo@...ovan.org>,
        linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linaro-mm-sig@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-buf: use wake_up_process() instead of wake_up_state()

Am 19.03.21 um 03:58 schrieb Wang Qing:
> Using wake_up_process() is more simpler and friendly,
> and it is more convenient for analysis and statistics
>
> Signed-off-by: Wang Qing <wangqing@...o.com>

Reviewed-by: Christian König <christian.koenig@....com>

Should I pick it up or do you want to push it through some other tree 
than DRM?

Thanks,
Christian.

> ---
>   drivers/dma-buf/dma-fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 7475e09..de51326
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -655,7 +655,7 @@ dma_fence_default_wait_cb(struct dma_fence *fence, struct dma_fence_cb *cb)
>   	struct default_wait_cb *wait =
>   		container_of(cb, struct default_wait_cb, base);
>   
> -	wake_up_state(wait->task, TASK_NORMAL);
> +	wake_up_process(wait->task);
>   }
>   
>   /**