linux-kernel - Re: [PATCH 10/17] auxdisplay: ht16k33: Remove unneeded error check in keypad probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae8bed58af4c760316a464ccb406b0a4@protonic.nl>
Date:   Tue, 23 Mar 2021 09:08:54 +0100
From:   robin <robin@...tonic.nl>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Miguel Ojeda <ojeda@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/17] auxdisplay: ht16k33: Remove unneeded error check in
 keypad probe()

On 2021-03-22 15:48, Geert Uytterhoeven wrote:
> There is no need to check the return code of input_register_device(),
> just propagate it to the caller.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/auxdisplay/ht16k33.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c 
> b/drivers/auxdisplay/ht16k33.c
> index 6d39f12054618fa5..13d18f218b4d196e 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -378,11 +378,7 @@ static int ht16k33_keypad_probe(struct i2c_client 
> *client,
> 
>  	ht16k33_keypad_stop(keypad->dev);
> 
> -	err = input_register_device(keypad->dev);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return input_register_device(keypad->dev);
>  }
> 
>  static int ht16k33_probe(struct i2c_client *client,

Acked-by: Robin van der Gracht <robin@...tonic.nl>