linux-kernel - Re: [PATCH] sched: remove the redundant comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210413122804.2d69fca6@gandalf.local.home>
Date:   Tue, 13 Apr 2021 12:28:04 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Dietmar Eggemann <dietmar.eggemann@....com>
Cc:     Hui Su <suhui@...u.com>, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        bsegall@...gle.com, mgorman@...e.de, bristot@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: remove the redundant comments

On Tue, 13 Apr 2021 10:36:07 +0200
Dietmar Eggemann <dietmar.eggemann@....com> wrote:

> > @@ -897,11 +897,6 @@ DECLARE_STATIC_KEY_FALSE(sched_uclamp_used);
> >  struct rq {
> >  	/* runqueue lock: */
> >  	raw_spinlock_t		lock;
> > -
> > -	/*
> > -	 * nr_running and cpu_load should be in the same cacheline because
> > -	 * remote CPUs use both these fields when doing load calculation.
> > -	 */
> >  	unsigned int		nr_running;
> >  #ifdef CONFIG_NUMA_BALANCING
> >  	unsigned int		nr_numa_running;  
> 
> I forgot to remove this snippet back then. LGTM.
> 
> Add a
> 
>   Fixes: 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
> 
> line.

It's just removing a comment. Should it really need a "Fixes" tag, which
will cause many people to look at it to determine if it should be
backported to stable?

-- Steve