linux-kernel - Re: [PATCH 10/13] dt-bindings: mfd: add vref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <906ea3e5-0aaa-2307-e6fb-aaac1a5e5d00@foss.st.com>
Date:   Thu, 15 Apr 2021 14:12:18 +0200
From:   Alexandre TORGUE <alexandre.torgue@...s.st.com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>, <arnd@...db.de>,
        <robh+dt@...nel.org>, Marek Vasut <marex@...x.de>,
        <jagan@...rulasolutions.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Marcin Sloniewski <marcin.sloniewski@...il.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-kernel@...r.kernel.org>, Lee Jones <lee.jones@...aro.org>,
        <kuba@...nel.org>
Subject: Re: [PATCH 10/13] dt-bindings: mfd: add vref_ddr-supply to st,stpmic1
 yaml

Hi Ahmad

On 4/15/21 12:51 PM, Ahmad Fatoum wrote:
> Hi,
> 
> On 15.04.21 12:10, Alexandre Torgue wrote:
>> Add vref_ddr-supply to the STPMIC1 regulators supplies pattern
>> list.
>>
>> Signed-off-by: Alexandre Torgue <alexandre.torgue@...s.st.com>
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>> index 305123e74a58..ffc32d209496 100644
>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
>> @@ -184,7 +184,7 @@ properties:
>>           additionalProperties: false
>>   
>>       patternProperties:
>> -      "^(buck[1-4]|ldo[1-6]|boost|pwr_sw[1-2])-supply$":
>> +      "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])-supply$":
> 
> IIRC, vref-ddr was a hack because a change in the regulator core broke
> the STM32MP1 boards. I believe vref-ddr should be removed altogether
> instead. It's supplied from BUCK2IN, which is already in the binding,
> so it's redundant.

Correct I forgot this point. We got random crash without this 
vddr_ref_supply but I don't know if regulator FW has been updated to fix 
it. If yes, I'll drop this one and remove
vddr_ref_supply from DT file.

> 
> Cheers,
> Ahmad
> 
>>           description: STPMIC1 voltage regulators supplies
>>   
>>         "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
>>
>