linux-kernel - Re: [PATCH-next] fs/btrfs: Fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210417115028.GA21778@ard0534>
Date:   Sat, 17 Apr 2021 12:50:28 +0100
From:   Khaled Romdhani <khaledromdhani216@...il.com>
To:     David Sterba <dsterba@...e.cz>, clm@...com, josef@...icpanda.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, khaledromdhani216@...il.com
Subject: Re: [PATCH-next] fs/btrfs: Fix uninitialized variable

On Fri, Apr 16, 2021 at 07:32:03PM +0200, David Sterba wrote:
> On Tue, Apr 13, 2021 at 02:06:04PM +0100, Khaled ROMDHANI wrote:
> > The variable zone is not initialized. It
> > may causes a failed assertion.
> 
> Failed assertion means the 2nd one checking that the result still fits
> to 32bit type. That would mean that none of the cases were hit, but all
> callers pass valid values.
> 
> It would be better to add a default: case to catch that explicitly,
> though hitting that is considered 'will not happen'.

Yes. I will send a V2.