linux-kernel - Re: [PATCH -next] clocksource/drivers/arm_arch_timer: Make symbol 'arch_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 08:14:42 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     <mark.rutland@....com>, <daniel.lezcano@...aro.org>,
        <tglx@...utronix.de>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Subject: Re: [PATCH -next] clocksource/drivers/arm_arch_timer: Make symbol 'arch_timer_rate1' static

[+ Jisheng Zhang]

On Tue, 11 May 2021 07:46:23 +0100,
Zou Wei <zou_wei@...wei.com> wrote:
> 
> The sparse tool complains as follows:
> 
> drivers/clocksource/arm_arch_timer.c:67:5: warning:
>  symbol 'arch_timer_rate1' was not declared. Should it be static?
> 
> This symbol is not used outside of arm_arch_timer.c, so marks it
> static.

It is worse than that. This variable is not used *at all*, and has
been added by e2bf384d4329 ("clocksource/drivers/arm_arch_timer: Add
__ro_after_init and __init"). Not sure how we missed that.

Please post a patch removing this variable altogether.

Thanks,

	M.

> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zou Wei <zou_wei@...wei.com>
> ---
>  drivers/clocksource/arm_arch_timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> index fe1a826..800aaa9 100644
> --- a/drivers/clocksource/arm_arch_timer.c
> +++ b/drivers/clocksource/arm_arch_timer.c
> @@ -64,7 +64,7 @@ struct arch_timer {
>  #define to_arch_timer(e) container_of(e, struct arch_timer, evt)
>  
>  static u32 arch_timer_rate __ro_after_init;
> -u32 arch_timer_rate1 __ro_after_init;
> +static u32 arch_timer_rate1 __ro_after_init;
>  static int arch_timer_ppi[ARCH_TIMER_MAX_TIMER_PPI] __ro_after_init;
>  
>  static const char *arch_timer_ppi_names[ARCH_TIMER_MAX_TIMER_PPI] = {
> -- 
> 2.6.2
> 
> 

-- 
Without deviation from the norm, progress is not possible.