linux-kernel - Re: [PATCH] arm64: dts: ti: k3-am65|j721e|am64: Map the dma / navigator subsystem via explicit ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6efd1297-d174-d915-44f7-a4ad6ff46b52@kernel.org>
Date:   Tue, 11 May 2021 10:14:55 +0300
From:   Tero Kristo <kristo@...nel.org>
To:     Nishanth Menon <nm@...com>, vigneshr@...com,
        grygorii.strashko@...com
Cc:     lokeshvutla@...com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm64: dts: ti: k3-am65|j721e|am64: Map the dma /
 navigator subsystem via explicit ranges

On 10/05/2021 17:54, Nishanth Menon wrote:
> Instead of using empty ranges property, lets map explicitly the address
> range that is mapped onto the dma / navigator subsystems (navss/dmss).
> 
> This is also exposed via the dtbs_check with dt-schema newer than
> 2021.03 version by throwing out following:
> arch/arm64/boot/dts/ti/k3-am654-base-board.dt.yaml: bus@...000: main-navss:
> {'type': 'object'} is not allowed for
> {'compatible': ['simple-mfd'], '#address-cells': [[2]], .....
> 
> This has already been correctly done for J7200, however was missed for
> other k3 SoCs. Fix that oversight.
> 
> Signed-off-by: Nishanth Menon <nm@...com>

Reviewed-by: Tero Kristo <kristo@...nel.org>

> ---
> 
> if possible, I'd like to pick this fixup for 5.13 window..
> 
>   arch/arm64/boot/dts/ti/k3-am64-main.dtsi        | 4 ++--
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi        | 4 ++--
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi       | 4 ++--
>   arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
>   5 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index a49e41021573..bb19db04a746 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -42,12 +42,12 @@ gic_its: msi-controller@...0000 {
>   		};
>   	};
>   
> -	dmss: dmss {
> +	dmss: bus@...00000 {
>   		compatible = "simple-mfd";
>   		#address-cells = <2>;
>   		#size-cells = <2>;
>   		dma-ranges;
> -		ranges;
> +		ranges = <0x00 0x48000000 0x00 0x48000000 0x00 0x06400000>;
>   
>   		ti,sci-dev-id = <25>;
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 037f9776c4c8..fea8260d33a8 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -445,11 +445,11 @@ intr_main_gpio: interrupt-controller@...000 {
>   		ti,interrupt-ranges = <0 392 32>;
>   	};
>   
> -	main-navss {
> +	main_navss: bus@...00000 {
>   		compatible = "simple-mfd";
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> -		ranges;
> +		ranges = <0x0 0x30800000 0x0 0x30800000 0x0 0xbc00000>;
>   		dma-coherent;
>   		dma-ranges;
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 0388c02c2203..f5b8ef2f5f77 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -116,11 +116,11 @@ adc {
>   		};
>   	};
>   
> -	mcu-navss {
> +	mcu_navss: bus@...80000 {
>   		compatible = "simple-mfd";
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> -		ranges;
> +		ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>;
>   		dma-coherent;
>   		dma-ranges;
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 512371e36a30..b2d25af872e2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -88,11 +88,11 @@ main_gpio_intr: interrupt-controller@...000 {
>   		ti,interrupt-ranges = <8 392 56>;
>   	};
>   
> -	main-navss {
> +	main_navss: bus@...00000 {
>   		compatible = "simple-mfd";
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> -		ranges;
> +		ranges = <0x00 0x30000000 0x00 0x30000000 0x00 0x0c400000>;
>   		dma-coherent;
>   		dma-ranges;
>   
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index ad12a5c9f209..172629fa3c7c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -250,11 +250,11 @@ adc {
>   		};
>   	};
>   
> -	mcu-navss {
> +	mcu_navss: bus@...80000 {
>   		compatible = "simple-mfd";
>   		#address-cells = <2>;
>   		#size-cells = <2>;
> -		ranges;
> +		ranges = <0x00 0x28380000 0x00 0x28380000 0x00 0x03880000>;
>   		dma-coherent;
>   		dma-ranges;
>   
>