linux-kernel - Re: linux-next: Fixes tag needs some work in the integrity tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1bb738125345283693fb41ea188e934b3d33ae75.camel@linux.ibm.com>
Date:   Tue, 01 Jun 2021 18:54:28 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        Dmitry Kasatkin <dmitry.kasatkin@...il.com>
Cc:     Roberto Sassu <roberto.sassu@...wei.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the integrity tree

On Wed, 2021-06-02 at 08:07 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   9eea2904292c ("evm: Execute evm_inode_init_security() only when an HMAC key is loaded")
> 
> Fixes tag
> 
>   Fixes: 26ddabfe96b ("evm: enable EVM when X509 certificate is loaded")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
> 
> Probably not worth rebasing for, but can be avoided in the future by
> setting core.abbrev to 12 (or more) or (for git v2.11 or later) just
> making sure it is not set (or set to "auto").

Stephen, thank you for catching the short hash.  It would be nice if
checkpatch would be updated to catch it.  I recently noticed
Documentation/process/submitting-patches.rst has directions for setting
up "--pretty=fixes".

thanks,

Mimi