[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20210828162349.GA824322@roeck-us.net>
Date: Sat, 28 Aug 2021 09:23:49 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Samuel Holland <samuel@...lland.org>
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>,
Rob Herring <robh+dt@...nel.org>,
Maxime Ripard <mripard@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, linux-watchdog@...r.kernel.org,
linux-kernel@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: watchdog: sunxi: Add compatible for
D1
On Wed, Aug 04, 2021 at 11:57:15PM -0500, Samuel Holland wrote:
> D1 keeps the same register layout and clock sources as the R329, but it
> adds a key field which must be set to update the watchdog's "CFG" and
> "MODE" registers. Therefore it is not backward-compatible.
>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Samuel Holland <samuel@...lland.org>
> Acked-by: Maxime Ripard <maxime@...no.tech>
Acked-by: Guenter Roeck <linux@...ck-us.net>
> ---
> Changes v1 to v2:
> - None.
>
> .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> index 8fa5b0d32381..6ef5e7caae80 100644
> --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> @@ -29,6 +29,7 @@ properties:
> - items:
> - const: allwinner,suniv-f1c100s-wdt
> - const: allwinner,sun4i-a10-wdt
> + - const: allwinner,sun20i-d1-wdt
>
> reg:
> maxItems: 1
> @@ -61,6 +62,7 @@ if:
> compatible:
> contains:
> enum:
> + - allwinner,sun20i-d1-wdt
> - allwinner,sun50i-r329-wdt
>
> then:
Powered by blists - more mailing lists