linux-kernel - Re: [PATCH] KVM: Drop unused kvm_dirty_gfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y28flyxj.fsf@vitty.brq.redhat.com>
Date:   Thu, 02 Sep 2021 18:33:44 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Peter Xu <peterx@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Cc:     peterx@...hat.com, Paolo Bonzini <pbonzini@...hat.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()

Peter Xu <peterx@...hat.com> writes:

> Drop the unused function as reported by test bot.

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
reallity you drop "kvm_dirty_gfn_invalid()".

>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Peter Xu <peterx@...hat.com>
> ---
>  virt/kvm/dirty_ring.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c
> index 7aafefc50aa7..88f4683198ea 100644
> --- a/virt/kvm/dirty_ring.c
> +++ b/virt/kvm/dirty_ring.c
> @@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
>  	gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
>  }
>  
> -static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
> -{
> -	return gfn->flags == 0;
> -}
> -
>  static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
>  {
>  	return gfn->flags & KVM_DIRTY_GFN_F_RESET;

-- 
Vitaly