linux-kernel - Re: [PATCH] pwm: ab8500: Don't check the return code of pwmchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210908091735.yxyr7wqpbyirkw73@pengutronix.de>
Date:   Wed, 8 Sep 2021 11:17:35 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     zhaoxiao <long870912@...il.com>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org,
        linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: ab8500: Don't check the return code of
 pwmchip_remove()

Hello zhaoxiao,

On Wed, Sep 08, 2021 at 02:02:00PM +0800, zhaoxiao wrote:
> pwmchip_remove() returns always 0. Don't use the value to make it
> possible to eventually change the function to return void. Also the
> driver core ignores the return value of ab8500_pwm_remove()
> and considers the device removed anyhow. So returning early results
> in a resource leak.
> 
> Signed-off-by: zhaoxiao <long870912@...il.com>

Can you please base your patches on top of linux-next? This patch is
invalid in the presence of 
https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git/commit/?h=for-next&id=14ac9e17f9bd4bd0dfe18e384a3c2ca8dfbffcc8

So this is waste of your (and my) time :-\

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |