linux-kernel - Re: [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f35822d036988a1a6b6e4dcaa46373e7@codeaurora.org>
Date:   Wed, 08 Sep 2021 14:47:37 +0530
From:   skakit@...eaurora.org
To:     Stephen Boyd <swboyd@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <agross@...nel.org>, Pavel Machek <pavel@....cz>,
        Rob Herring <robh+dt@...nel.org>, mka@...omium.org,
        kgunda@...eaurora.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver

On 2021-09-08 01:50, Stephen Boyd wrote:
> Quoting satya priya (2021-09-06 03:41:06)
>> Add pm8350c compatible and lpg_data to the driver.
>> 
>> Signed-off-by: satya priya <skakit@...eaurora.org>
>> ---
>>  drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c 
>> b/drivers/leds/rgb/leds-qcom-lpg.c
>> index 327e81a..6ee80d6 100644
>> --- a/drivers/leds/rgb/leds-qcom-lpg.c
>> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
>> @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = 
>> {
>>         },
>>  };
>> 
>> +static const struct lpg_data pm8350c_pwm_data = {
>> +       .pwm_9bit_mask = BIT(2),
>> +
>> +       .num_channels = 1,
>> +       .channels = (struct lpg_channel_data[]) {
> 
> Can this be const struct lpg_channel_data? I think that will move it to
> rodata which is only a good thing.
> 

I agree.
@Bjorn, can we make it const struct?

>> +               { .base = 0xeb00 },
>> +       },
>> +};
>> +
>>  static const struct of_device_id lpg_of_table[] = {
>>         { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data 
>> },
>>         { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data 
>> },
>> +       { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data 
>> },
>>         { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
>>         { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
>>         { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },