linux-kernel - Re: [PATCH] x86/umip: Add a umip= cmdline switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUDTZQ9MHl5hXas3@zn.tnic>
Date:   Tue, 14 Sep 2021 18:52:53 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Cc:     X86 ML <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
        Marcus Rückert <mrueckert@...e.com>
Subject: Re: [PATCH] x86/umip: Add a umip= cmdline switch

On Mon, Sep 13, 2021 at 02:45:03PM -0700, Ricardo Neri wrote:
> Strictly, this hunk does not logically belong to this patch. I guess it
> is harmless, though. Admittedly, the new line should have been there
> since umip.c was added.

Yeah, I don't like crammed code - that's why I've added it.

> Wouldn't it be better to use parse_option_str() with __setup("umip=",
> parse_umip_param)? This would avoid the first two checks.

Sure.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette