linux-kernel - Re: [PATCH] sparc32: Page align size in arch_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210914112646.GA18171@lst.de>
Date:   Tue, 14 Sep 2021 13:26:46 +0200
From:   Christoph Hellwig <hch@....de>
To:     Andreas Larsson <andreas@...sler.com>
Cc:     Christoph Hellwig <hch@....de>, David Miller <davem@...emloft.net>,
        sparclinux@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
        linux-kernel@...r.kernel.org, software@...sler.com
Subject: Re: [PATCH] sparc32: Page align size in arch_dma_alloc

On Tue, Sep 14, 2021 at 01:16:16PM +0200, Andreas Larsson wrote:
> Before the patch, arch_dma_alloc did via srmmu_mapiorange set up pages with 
> SRMMU_PRIV, which is all fine as it sets up kernel buffers. With your patch 
> we get PAGE_KERNEL as an argument to dma_pgprot in the corresponding call 
> path that earlier lead to arch_dma_alloc. PAGE_KERNEL already includes 
> SRMMU_PRIV so adding it again should not be necessary.

You're right, I missed that PAGE_KERNEL already includes SRMMU_PRIV.