linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: ipq4019: add dwc3 arch spec compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YUgLNZlKbaqeCQYp@builder.lan>
Date:   Sun, 19 Sep 2021 23:16:53 -0500
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     David Heidelberg <david@...t.cz>
Cc:     Andy Gross <agross@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019: add dwc3 arch spec
 compatible

On Wed 08 Sep 14:33 CDT 2021, David Heidelberg wrote:

> To be compilant with qcom,dwc3 definition
>  - add compatible
>  - rename dwc3@ to usb@
> 
> No functional changes intended.
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>  arch/arm/boot/dts/qcom-ipq4019.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> index a3ae5458ac68..25b7e10537df 100644
> --- a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> +++ b/arch/arm/boot/dts/qcom-ipq4019.dtsi
> @@ -637,7 +637,7 @@ usb3_hs_phy: hsphy@...00 {
>  		};
>  
>  		usb3: usb3@...8800 {
> -			compatible = "qcom,dwc3";
> +			compatible = "qcom,ipq4019-dwc3", "qcom,dwc3";
>  			reg = <0x8af8800 0x100>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> @@ -648,7 +648,7 @@ usb3: usb3@...8800 {
>  			ranges;
>  			status = "disabled";
>  
> -			dwc3@...0000 {
> +			usb@...0000 {

As noted in a recent discussion, this causes the UDC name exposed in
sysfs to change. So even though it's contradicting the binding let's
keep it unchanged for now.

The compatible part looks good though, so can you please respin this
patch with that part only?

Thanks,
Bjorn

>  				compatible = "snps,dwc3";
>  				reg = <0x8a00000 0xf8000>;
>  				interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
> @@ -669,7 +669,7 @@ usb2_hs_phy: hsphy@...00 {
>  		};
>  
>  		usb2: usb2@...8800 {
> -			compatible = "qcom,dwc3";
> +			compatible = "qcom,ipq4019-dwc3", "qcom,dwc3";
>  			reg = <0x60f8800 0x100>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> @@ -680,7 +680,7 @@ usb2: usb2@...8800 {
>  			ranges;
>  			status = "disabled";
>  
> -			dwc3@...0000 {
> +			usb@...0000 {
>  				compatible = "snps,dwc3";
>  				reg = <0x6000000 0xf8000>;
>  				interrupts = <GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>;
> -- 
> 2.33.0
>