Message-ID: <CAMe9rOp9ihmjTNMV7WxDuFmwcOYvEGVEzCZDTa2nQri8DvPx8Q@mail.gmail.com>
Date:   Wed, 22 Sep 2021 17:07:19 -0700
From:   "H.J. Lu" <hjl.tools@...il.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     "Zhang, Xiang1" <xiang1.zhang@...el.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "Lutomirski, Andy" <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Andi Kleen <ak@...ux.intel.com>,
        Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Carlos O'Donell" <carlos@...hat.com>,
        Marco Elver <elver@...gle.com>,
        Taras Madan <tarasmadan@...gle.com>,
        Hongtao Liu <hongtao.liu@...el.com>
Subject: Re: [RFC 0/9] Linear Address Masking enabling

On Wed, Sep 22, 2021 at 5:54 AM Dmitry Vyukov <dvyukov@...gle.com> wrote:
>
> On Wed, 22 Sept 2021 at 03:15, Zhang, Xiang1 <xiang1.zhang@...el.com> wrote:
> >
> > There are already in llvm.org.
> > One of my old patch is https://reviews.llvm.org/D102472 which has been committed by https://reviews.llvm.org/D102901  and https://reviews.llvm.org/D109790
>
> Hi Xiang,
>
> Good sanitizer patches are upstream!
>
> Please help me to understand the status of other pieces (H.J. you
> probably talked about this yesterday, but I wasn't able to build a
> complete picture during the talk, I think it will be useful to have
> this in written form).
>
> 1. The presentation mentions "GCC: enable memory tagging with LAM in
> x86 codegen".
> What exactly is needed? Isn't LAM transparent for codegen? What's the
> status in gcc? Does a corresponding change need to be done in llvm?

The current LAM enabled GCC is on users/intel/lam/master branch at

https://gitlab.com/x86-gcc/gcc/-/tree/users/intel/lam/master

Hongtao, please sync libsanitizer with compiler-rt and check if
compiler-rt is up to date.  The LAM enabled GCC run-time uses
the proposed tagged address API.

> 2. "Enable LAM in binutils".
> This is already upstream in binutils 2.36, right?

Correct.

> 3. The mentioned glibc patch:
> http://patchwork.ozlabs.org/project/glibc/patch/20210211173711.71736-1-hjl.tools@gmail.com/
> Not upstream yet, targeting glibc 2.34.

It is targeting glibc 2.35 now.

> 4. "Avoid pointer operations incompatible with LAM. memmove: mask out
> memory tags before comparing pointers".
> Is this upstream? Where is the patch? Are there other similar patches?

The LAM enabled glibc is on users/intel/lam/master branch at:

https://gitlab.com/x86-glibc/glibc/-/tree/users/intel/lam/master

I am considering moving the tagged address API to libc_nonshared.a
for easy backport.

> As a side note, regarding the memmove change: do we really need it?
> Memory regions can overlap only if they come from the same
> allocation/base object. If they come from different allocations, they
> can't overlap (undefined behavior already).

The change isn't needed and has been removed.

> 5. Do we need any additional enabling changes in clang/llvm?

I proposed the tagged address API to support LAM.  compiler-rt
should use it.

> 6. The kernel patches (this email thread) depend on the CET patches
> (for the interface part only). And the CET patches is this, right?
> https://lore.kernel.org/linux-doc/?q=x86%2Fcet%2Fshstk

Yes.

> 7. Do I miss anything else?

No.

> H.J. please upload your slides here:
> https://linuxplumbersconf.org/event/11/contributions/1010/
> It would help with links and copy-pasting text.

Done.

H.J.
> FTR here is the link to the Plumbers talk:
> https://youtu.be/zUw0ZVXCwoM?t=10456
>
> Thank you
>
>
> > BR
> > Xiang
> >
> > -----Original Message-----
> > From: H.J. Lu <hjl.tools@...il.com>
> > Sent: Wednesday, September 22, 2021 1:16 AM
> > To: Dmitry Vyukov <dvyukov@...gle.com>
> > Cc: Kirill A. Shutemov <kirill@...temov.name>; Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>; Dave Hansen <dave.hansen@...ux.intel.com>; Lutomirski, Andy <luto@...nel.org>; Peter Zijlstra <peterz@...radead.org>; the arch/x86 maintainers <x86@...nel.org>; Andrey Ryabinin <aryabinin@...tuozzo.com>; Alexander Potapenko <glider@...gle.com>; Catalin Marinas <catalin.marinas@....com>; Will Deacon <will@...nel.org>; Andi Kleen <ak@...ux.intel.com>; Linux-MM <linux-mm@...ck.org>; LKML <linux-kernel@...r.kernel.org>; Carlos O'Donell <carlos@...hat.com>; Marco Elver <elver@...gle.com>; Taras Madan <tarasmadan@...gle.com>; Zhang, Xiang1 <xiang1.zhang@...el.com>
> > Subject: Re: [RFC 0/9] Linear Address Masking enabling
> >
> > On Tue, Sep 21, 2021 at 9:52 AM Dmitry Vyukov <dvyukov@...gle.com> wrote:
> > >
> > > On Sun, 7 Feb 2021 at 15:11, Kirill A. Shutemov <kirill@...temov.name> wrote:
> > > >
> > > > On Sun, Feb 07, 2021 at 09:24:23AM +0100, Dmitry Vyukov wrote:
> > > > > On Fri, Feb 5, 2021 at 4:16 PM Kirill A. Shutemov
> > > > > <kirill.shutemov@...ux.intel.com> wrote:
> > > > > >
> > > > > > Linear Address Masking[1] (LAM) modifies the checking that is
> > > > > > applied to 64-bit linear addresses, allowing software to use of
> > > > > > the untranslated address bits for metadata.
> > > > > >
> > > > > > The patchset brings support for LAM for userspace addresses.
> > > > > >
> > > > > > The most sensitive part of enabling is change in tlb.c, where
> > > > > > CR3 flags get set. Please take a look that what I'm doing makes sense.
> > > > > >
> > > > > > The patchset is RFC quality and the code requires more testing
> > > > > > before it can be applied.
> > > > > >
> > > > > > The userspace API is not finalized yet. The patchset extends API
> > > > > > used by
> > > > > > ARM64: PR_GET/SET_TAGGED_ADDR_CTRL. The API is adjusted to not
> > > > > > imply ARM
> > > > > > TBI: it now allows to request a number of bits of metadata
> > > > > > needed and report where these bits are located in the address.
> > > > > >
> > > > > > There's an alternative proposal[2] for the API based on Intel
> > > > > > CET interface. Please let us know if you prefer one over another.
> > > > > >
> > > > > > The feature competes for bits with 5-level paging: LAM_U48 makes
> > > > > > it impossible to map anything about 47-bits. The patchset made
> > > > > > these capability mutually exclusive: whatever used first wins.
> > > > > > LAM_U57 can be combined with mappings above 47-bits.
> > > > > >
> > > > > > I include QEMU patch in case if somebody wants to play with the feature.
> > > > >
> > > > > Exciting! Do you plan to send the QEMU patch to QEMU?
> > > >
> > > > Sure. After more testing, once I'm sure it's conforming to the hardware.
> > >
> > > A follow up after H.J.'s LPC talk:
> > > https://linuxplumbersconf.org/event/11/contributions/1010/
> > > (also +Carlos)
> > >
> > > As far as I understood, this kernel series depends on the Intel CET patches.
> > >
> > > Where are these compiler-rt patches that block gcc support?
> >
> > Hi Xiang,
> >
> > Please share your compiler-rt changes for LAM.
> >
> > --
> > H.J.



--
H.J.

Powered by blists - more mailing lists