lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 04 Oct 2021 17:09:18 -0600 From: Jonathan Corbet <corbet@....net> To: Kees Cook <keescook@...omium.org> Cc: Kees Cook <keescook@...omium.org>, Randy Dunlap <rdunlap@...radead.org>, Joe Perches <joe@...ches.com>, Alexey Dobriyan <adobriyan@...il.com>, Nick Desaulniers <ndesaulniers@...gle.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Rasmus Villemoes <linux@...musvillemoes.dk>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-hardening@...r.kernel.org Subject: Re: [PATCH v4] docs: Explain the desired position of function attributes Kees Cook <keescook@...omium.org> writes: > While discussing how to format the addition of various function > attributes, some "unwritten rules" of ordering surfaced[1]. Capture as > close as possible to Linus's preferences for future reference. > > (Though I note the dissent voiced by Joe Perches, Alexey Dobriyan, and > others that would prefer all attributes live on a separate leading line.) > > [1] https://lore.kernel.org/mm-commits/CAHk-=wiOCLRny5aifWNhr621kYrJwhfURsa0vFPeUEm8mF0ufg@mail.gmail.com/ > > Signed-off-by: Kees Cook <keescook@...omium.org> > --- > v4: > - fix another stray "void"! This is why code needs a compiler... (thx randy) > --- > Documentation/process/coding-style.rst | 30 ++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Did I ever mention that I *hate* coding-style patches? :) In this case I think we're as close as to consensus as things get. In the absence of a strong reason to the contrary, I'll apply this before too long. Thanks, jon
Powered by blists - more mailing lists