linux-kernel - Re: [PATCH 1/3] wcn36xx: add debug prints for sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <163532120872.19793.15468481505724352001.kvalo@codeaurora.org>
Date:   Wed, 27 Oct 2021 07:53:37 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Benjamin Li <benl@...areup.com>
Cc:     Joseph Gates <jgates@...areup.com>,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        linux-arm-msm@...r.kernel.org, Benjamin Li <benl@...areup.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eugene Krasnikov <k.eugene.e@...il.com>,
        "John W. Linville" <linville@...driver.com>,
        wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] wcn36xx: add debug prints for sw_scan start/complete

Benjamin Li <benl@...areup.com> wrote:

> Add some MAC debug prints for more easily demarcating a software scan
> when parsing logs.
> 
> Signed-off-by: Benjamin Li <benl@...areup.com>

Failed to build:

In file included from ./include/linux/bitops.h:7,
                 from ./include/linux/kernel.h:12,
                 from ./include/linux/interrupt.h:6,
                 from drivers/net/wireless/ath/wcn36xx/dxe.c:25:
drivers/net/wireless/ath/wcn36xx/dxe.c: In function '_wcn36xx_dxe_tx_channel_is_empty':
./include/linux/typecheck.h:12:25: error: comparison of distinct pointer types lacks a cast [-Werror]
   12 |         (void)(&__dummy == &__dummy2); \
      |                         ^~
./include/linux/spinlock.h:255:17: note: in expansion of macro 'typecheck'
  255 |                 typecheck(unsigned long, flags);        \
      |                 ^~~~~~~~~
./include/linux/spinlock.h:393:9: note: in expansion of macro 'raw_spin_lock_irqsave'
  393 |         raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
      |         ^~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/wcn36xx/dxe.c:844:9: note: in expansion of macro 'spin_lock_irqsave'
  844 |         spin_lock_irqsave(&ch->lock, flags);
      |         ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:277: drivers/net/wireless/ath/wcn36xx/dxe.o] Error 1
make[4]: *** [scripts/Makefile.build:540: drivers/net/wireless/ath/wcn36xx] Error 2
make[3]: *** [scripts/Makefile.build:540: drivers/net/wireless/ath] Error 2
make[2]: *** [scripts/Makefile.build:540: drivers/net/wireless] Error 2
make[1]: *** [scripts/Makefile.build:540: drivers/net] Error 2
make: *** [Makefile:1868: drivers] Error 2

3 patches set to Changes Requested.

12579221 [1/3] wcn36xx: add debug prints for sw_scan start/complete
12579223 [2/3] wcn36xx: implement flush op to speed up connected scan
12579225 [3/3] wcn36xx: ensure pairing of init_scan/finish_scan and start_scan/end_scan

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211023003949.3082900-2-benl@squareup.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches