linux-kernel - Re: [PATCH] mfd: simple-mfd-i2c: Select MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1FD0767C-3BF3-46D3-8C7D-BA31F9D7AE0D@walle.cc>
Date:   Wed, 03 Nov 2021 08:36:42 +0100
From:   Michael Walle <michael@...le.cc>
To:     Lee Jones <lee.jones@...aro.org>
CC:     Robert Marko <robert.marko@...tura.hr>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error

Am 3. November 2021 08:32:28 MEZ schrieb Lee Jones <lee.jones@...aro.org>:
>On Tue, 02 Nov 2021, Michael Walle wrote:
>
>> Am 2021-11-02 12:17, schrieb Lee Jones:
>> > On Tue, 02 Nov 2021, Robert Marko wrote:
>> > 
>> > > MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build
>> > > error:
>> > > 
>> > > aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function
>> > > `simple_mfd_i2c_probe':
>> > > drivers/mfd/simple-mfd-i2c.c:55: undefined reference to
>> > > `devm_mfd_add_devices'
>> > 
>> > What is your use-case?
>> > 
>> > How are you enabling this symbol?
>> 
>> Mh? drivers/mfd/simple-mfd-i2c.c is using devm_mfd_add_devices which
>> is provided by drivers/mfd/core.c. So select MFD_CORE is clearly
>> missing here, no? I mean most of the MFD drivers do a "select MFD_CORE".
>
>I'm not debating that.  The patch is fine.
>
>I am however, interested in how MFD_CORE is enabled for MFD_SL28CPLD.

Because I'm mostly using the arch defconfig (arm64) it
must have missed it because it was probably already 
enabled by another mfd driver. 

-michael