linux-kernel - Re: [PATCH v4 00/16] Basic StarFive JH7100 RISC-V SoC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcCL1eSMaZy_KXdfY=UyTy-hxz4XN5TGkXd6Cf8p+pRNw@mail.gmail.com>
Date:   Tue, 16 Nov 2021 18:13:04 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Emil Renner Berthing <kernel@...il.dk>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        DTML <devicetree@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Maximilian Luz <luzmaximilian@...il.com>,
        Sagar Kadam <sagar.kadam@...ive.com>,
        Drew Fustini <drew@...gleboard.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Michael Zhu <michael.zhu@...rfivetech.com>,
        Fu Wei <tekkamanninja@...il.com>,
        Anup Patel <anup.patel@....com>,
        Atish Patra <atish.patra@....com>,
        Matteo Croce <mcroce@...rosoft.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 00/16] Basic StarFive JH7100 RISC-V SoC support

On Tue, Nov 16, 2021 at 6:09 PM Arnd Bergmann <arnd@...db.de> wrote:
> On Tue, Nov 16, 2021 at 4:01 PM Emil Renner Berthing <kernel@...il.dk> wrote:

...

> One general (minor) comment about the patches: please put your own
> 'Signed-off-by'
> into the last line of the patch description, below all the lines you
> took from other people, so
> instead of:
>
> | Signed-off-by: Emil Renner Berthing <kernel@...il.dk>
> | Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> | Acked-by: Rob Herring <robh@...nel.org>
>
> do this:
>
> | Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> | Acked-by: Rob Herring <robh@...nel.org>
> | Signed-off-by: Emil Renner Berthing <kernel@...il.dk>

Why?
Submitting Patches tells about chronological order and last SoB to be
from the submitter.
These both are correct. Note the difference between 'last SoB' and
'SoB to be last [line]'.

Here is the excerpt:
"Notably, the last Signed-off-by: must always be that of the developer
submitting the patch."

-- 
With Best Regards,
Andy Shevchenko