linux-kernel - RE: [PATCH v9 5/5] MAINTAINERS: Add maintainer for xilinx-ams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR02MB69169E3F24E8EBE3DD754AB1A99A9@BY5PR02MB6916.namprd02.prod.outlook.com>
Date:   Wed, 17 Nov 2021 21:57:43 +0000
From:   Anand Ashok Dumbre <ANANDASH@...inx.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Joe Perches <joe@...ches.com>
CC:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        git <git@...inx.com>, Michal Simek <michals@...inx.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>
Subject: RE: [PATCH v9 5/5] MAINTAINERS: Add maintainer for xilinx-ams

Hi Andy,

Thanks for the review.

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Wednesday 17 November 2021 5:09 PM
> To: Joe Perches <joe@...ches.com>
> Cc: Anand Ashok Dumbre <ANANDASH@...inx.com>; Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com>; linux-kernel@...r.kernel.org;
> jic23@...nel.org; lars@...afoo.de; linux-iio@...r.kernel.org; git
> <git@...inx.com>; Michal Simek <michals@...inx.com>;
> gregkh@...uxfoundation.org; rafael@...nel.org; linux-acpi@...r.kernel.org;
> heikki.krogerus@...ux.intel.com
> Subject: Re: [PATCH v9 5/5] MAINTAINERS: Add maintainer for xilinx-ams
> 
> On Wed, Nov 17, 2021 at 6:05 PM Joe Perches <joe@...ches.com> wrote:
> > On Wed, 2021-11-17 at 17:17 +0200, Andy Shevchenko wrote:
> > > On Wed, Nov 17, 2021 at 5:00 PM Anand Ashok Dumbre
> <ANANDASH@...inx.com> wrote:
> > > > > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > > > Sent: Tuesday 16 November 2021 5:42 PM On Tue, Nov 16, 2021 at
> > > > > 03:08:42PM +0000, Anand Ashok Dumbre wrote:
> 
> ...
> 
> > > > > Have you run checkpatch?
> > > >
> > > > Yes I did.
> > > > I don't see any error on this.
> > >
> > > Hmm... Perhaps it needs an unobvious parameter?
> > > Joe, X is definitely after M, any idea why checkpatch hasn't caught this
> up?
> >
> > This is the suggested patch below right?
> 
> Correct.
> 
> > https://lore.kernel.org/lkml/20211116150842.1051-6-
> anand.ashok.dumbre@
> > xilinx.com/
> >
> > It looks OK to me.
> 
> How come? See below.
> 
> > What do you think checkpatch is supposed to find?
> 
> XILINX AXI ETHERNET DRIVER
> M:      Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> S:      Maintained
> F:      drivers/net/ethernet/xilinx/xilinx_axienet*
> 
> --> patch adds XILINX AMS DRIVER here !!!
> 
> XILINX CAN DRIVER
> 
> To me AMS should precede AXI and not the other way around. Agree?

Got it! Needs to be alphabetical.

> 
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20640,6 +20640,13 @@ M:     Radhey Shyam Pandey
> <radhey.shyam.pandey@...inx.com>
> >  S:     Maintained
> >  F:     drivers/net/ethernet/xilinx/xilinx_axienet*
> >
> > +XILINX AMS DRIVER
> > +M:     Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>
> > +L:     linux-iio@...r.kernel.org
> > +S:     Maintained
> > +F:     Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > +F:     drivers/iio/adc/xilinx-ams.c
> > +
> >  XILINX CAN DRIVER
> >  M:     Appana Durga Kedareswara rao <appana.durga.rao@...inx.com>
> >  R:     Naga Sureshkumar Relli <naga.sureshkumar.relli@...inx.com>
> > --
> > 2.17.1
> >
> >
> >
> 
> 
> --
> With Best Regards,
> Andy Shevchenko

Thanks,
Anand